Merged
Conversation
Contributor
Author
|
Looks like it works. I copied the |
* Update logcleaner.cpp * Update autolabor.cpp
ab9rf
requested changes
Mar 2, 2026
plugins/autolabor/autolabor.cpp
Outdated
| } | ||
|
|
||
| if (world->frame_counter - cycle_timestamp <= CYCLE_TICKS) | ||
| if (world->frame_counter - cycle_timestamp < CYCLE_TICKS) |
Member
There was a problem hiding this comment.
while there might be merit to this change, it's unnecessary to dealing with a defect in a pending release. feel free to repropose in a separate PR
even when not in a pre-release feature freeze it's best to keep PRs to a single issue, and a PR that is intended to fix a defect in a imminently pending release should absolutely only address the specific defect and nothing else
out of scope for this PR
ab9rf
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
logcleanerto use ticks instead of frames, usingautolaboras reference. Also corrected docs that it runs "approximately" every 100 ticks.