Buy Crypto on Ethereum and BSC, Pricing and Payout changes#410
Merged
Conversation
* [DEV-411] implemented generic payout module, happy path * [DEV-411] added payout module to payment parent module * [DEV-411] refactored buy-crypto to use new payout service * [DEV-411] finished refactoring and cleanup of buy-crypto * [DEV-411] small improvements after first test run * [DEV-411] removed unnecessary imports * [DEV-411] added node choice capability, depending on context * [DEV-411] implemented corner cases protection and non-recoverable scenario * [DEV-411] created db migration * [DEV-411] slightly improved log for new payout orders * [DEV-411] slightly improved log for token payout * [DEV-411] returned INT wallet address config * [DEV-667] added ethereum configuration * [DEV-667] regrouped blockchain layer, added ethereum module * [DEV-667] scaffolded ethereum service and client * [DEV-667] interim progress on payout module adaption * [DEV-667] finished initial payout module adaption * [DEV-667] extracted logs service * [DEV-667] refactored dex module for ethereum * [DEV-667] first e2e ETH buy run * [DEV-667] implemented remaining part of asset fetch and liquidity calculation * [DEV-667] defined pricing interface * [DEV-667] pricing paths configuration - WIP * [DEV-667] renamed path aliases - WIP * [DEV-667] added fixer service * [DEV-667] fixed price requests from buy-crypto and staking * [DEV-667] renamed ethereum blockchain directory * [DEV-667] extracted ETH_API_KEY to separate variable and config * [DEV-667] changed reference asset check logic * [DEV-667] added bnb clone of ethereum * [DEV-667] improved logs in pricings-step class * [DEV-667] added health checks to payout and prepare defi strategies * [DEV-667] improved payout designation logic, to catch only timeouts * [DEV-667] BNB transaction working e2e * [DEV-667] finished pricing module cleanup * [DEV-667] remaining modules cleanup interim progress * [DEV-667] first version of EVM shared functionality * [DEV-667] removed redundant generic types * [DEV-667] finished strategies resturcturing * [DEV-667] removed denomination from evm-client * [DEV-667] implemented part of PR-354 comments * [DEV-667] fixed DI and initialization issues * [DEV-667] added await for sending mail * [DEV-667] cleanup after merge * [DEV-667] restructured mocks directories and fixed the tests * [DEV-667] restructured remaining mocks directories * [DEV-667] implemented buy-crypto entites unit tests * [DEV-667] implemented liquidity-orider entity unit tests * [DEV-667] implemented payout-orider entity unit tests * [DEV-667] implemented factories unit tests * [DEV-667] implemented unit tests for strategies facades * [DEV-667] implemented price paths and steps specifications unit tests * [DEV-667] added DEX module high level docs * [DEV-667] slightly updated DEX module high level docs * [DEV-667] declared basic integration tests scenarios * [DEV-667] implemented payout defichain unit tests * [DEV-667] implemented payout defichain token unit tests * [DEV-667] added extensive logs to price requests * [DEV-667] interim progress on pricing module testing * [DEV-667] finished pricing component integration tests * [DEV-667] skipped non-implemented tests * [DEV-667] extended buy-crypto inntegration test scenarios * [DEV-667] generalized defichain payout sending logic * [DEV-667] removed unnecessary comment * [DEV-667] improved log message for pricing requests * [DEV-667] integrated currency service * [DEV-667] small syntax cleanup * [DEV-667] minor fixes after first test run * [DEV-667] reflected couple of testing findings * [DEV-667] fixed post merge errors * [DEV-667] fixes after second test run findings * [DEV-667] changed gsa limit to number * [DEV-667] addressed PR comments * [DEV-667] fixed errors after develop merge * [DEV-667] implemented setting output reference to BTC for non-USD Fiat input * [DEV-667] removed Fixer env and configuration * [DEV-667] adjusted setting output reference to BTC for non-USD Fiat input * [DEV-667] added pricing path USDC -> USDT * [DEV-667] removed redundant TODOs * [DEV-667] fixed ETH liquidity purchase mail * [DEV-667] added blockchain column to migration * [DEV-667] removed IS NOT NULL constraint from asset * [DEV-667] removed evm explorers configs * [DEV-667] Updated environment * [DEV-667] Fixed BSC gateway URL * [DEV-667] Fixed migration Co-authored-by: David May <david.leo.may@gmail.com>
davidleomay
approved these changes
Sep 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Checklist
Pre-Release
Post-Release