Release: develop -> main#4241
Merged
Merged
Conversation
…over asset openings (#4239) * fix(accounting): read the FinanceLog { total } balance objects in cutover asset openings paymentDepositBalance and manualLiqPosition are serialized as { total } objects but were typed and summed as bare numbers, so every asset carrying one of them produced a NaN opening and the cutover failed on the Postgres bigint insert. Type the DTO to the real shape, read .total in assetOpeningAmount, and fail loud on any non-finite leg amount in prepareLeg before it reaches the driver. * refactor(log): type the getAssetLog accumulator against the AssetLog DTO The untyped {} accumulator is why the writer/DTO shape drift behind the cutover NaN incident was never compiler-checked. Typing it surfaced a second stale declaration: the writer's error line is disabled and the serialized entries carry no error field, so the DTO must not promise one.
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
July 16, 2026 15:44
TaprootFreak
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist