feat(monitoring): add Bank Frick to the bank-balance observer#4255
Merged
Conversation
The bank-balance monitoring observer aggregated only Olkypay and Yapeal balances, so Bank Frick balance drift was not monitored. Add a getFrick() helper mirroring getYapeal(), gated by frickService.isAvailable() in fetch() and reusing the existing BankFrickService.getBalances() (the same source the liquidity balance adapter already uses). A missing available balance fails loud rather than silently substituting the booked balance.
Collaborator
Author
|
Reviewed in a combined correctness/conformance pass with no findings. getFrick() mirrors the existing Yapeal helper and reuses the same balance source the liquidity adapter already uses; a missing available balance fails loud rather than substituting the booked balance. |
TaprootFreak
marked this pull request as ready for review
July 16, 2026 22:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The bank-balance monitoring observer (
bank.observer.ts) aggregated only Olkypay and Yapealbalances, so Bank Frick balance drift was not monitored.
Changes
getFrick()helper mirroringgetYapeal(), gated byfrickService.isAvailable()infetch(), reusing the existingBankFrickService.getBalances()— the same source the liquiditybalance adapter already uses.
availableBalancefails loud (consistent with the liquidity adapter's Bank Frick case)rather than silently substituting the booked balance.
fetch()aggregation.