fix(bank): attribute Bank Frick CHF bank-to-Scrypt transfers in the reconciliation#4257
Merged
Conversation
Collaborator
Author
|
Reviewed for correctness/equity-safety and conformance. The correctness pass confirmed — via direct code tracing and a fix-reverted control test run — that the implemented Bank->Scrypt direction cannot double-count and leaves Yapeal CHF bit-identical, and that the Scrypt->Bank attribution is correctly left unchanged (an exchange-tx carries no destination-bank field, so a per-currency target would double-count the same withdrawal). The one conformance finding (a comment-clarity ambiguity) was fixed. Note: this PR is stacked on #4252 — for a feature-base PR GitHub runs only the review check; the full build/test suite runs automatically once #4252 merges and this PR retargets to develop. Merge after #4252. |
…econciliation Symmetric to the EUR fix: the CHF side of the log-job Scrypt reconciliation hardcoded the Yapeal CHF IBAN, so a Bank Frick CHF bank_tx into or out of Scrypt was dropped from the pending computation (Bank Frick CHF is a newly-active fallback account). Widen the two CHF Scrypt bank_tx filters to include the Bank Frick CHF IBAN, so a Frick CHF bank-to-Scrypt transfer attributes to the Frick/CHF asset and a Frick CHF credit can settle a previously-unmatched pending withdrawal. Yapeal CHF stays bit-identical when there is no Frick activity, and each bank_tx attributes to exactly one asset (per-row IBAN match), so there is no double-count. The Scrypt-withdrawal attribution target is deliberately left hardcoded to the Yapeal CHF IBAN: an exchange-tx carries no field identifying the destination bank, so making that target per-asset would tautologically match every CHF bank asset and double-count the same withdrawal. Leaving it keeps the total counted exactly once.
TaprootFreak
force-pushed
the
feat/frick-chf-scrypt
branch
from
July 17, 2026 21:17
c46f42b to
8d95206
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #4252, which fixed the EUR side of the log-job Scrypt reconciliation for Bank Frick.
This does the same on the CHF side.
The CHF Scrypt-reconciliation
bank_txfilters hardcoded the Yapeal CHF IBAN, so a Bank Frick CHFbank_txinto or out of Scrypt was dropped from the pending computation (Bank Frick CHF is anewly-active fallback account).
Changes
bank_txfilters (chfSenderScryptBankTx,chfReceiverScryptBankTx) toinclude the Bank Frick CHF IBAN, so a Frick CHF bank→Scrypt transfer attributes to the Frick/CHF
asset, and a Frick CHF credit can settle a previously-unmatched pending withdrawal.
transfer attributes to Frick/CHF (not Yapeal), with no double-count.
Scope / safety
includesreduces to the priorequality); each
bank_txattributes to exactly one asset (per-row IBAN match viaisBankMatching), so there is no double-count.exchange-tx (Scrypt withdrawal) carries no field identifying the destination bank, so making that
target per-asset would tautologically match every CHF bank asset and double-count the same
withdrawal. Leaving it keeps the total counted exactly once — the per-bank split of an unmatched
pending CHF Scrypt withdrawal is a pre-existing, transient limitation, not a regression.
Note
Stacked on #4252 (base
feat/frick-asset-wiring); retarget todeveloponce #4252 merges.