chore(deps): override tar to >=7.5.19 (critical audit GHSA-23hp-3jrh-7fpw)#4300
Merged
Merged
Conversation
Collaborator
Author
|
CI fully green — the |
TaprootFreak
marked this pull request as ready for review
July 21, 2026 08:25
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a single line to the existing
overridesblock inpackage.json:This deduplicates both
tarpaths in the tree totar@7.5.20:tar@4.4.19(viaweb3->swarm-js)tar@6.2.1(viabcrypt->@mapbox/node-pre-gyp)Why
CI's
Security auditstep runsnpm audit --audit-level=criticaland currently fails repo-wide on GHSA-23hp-3jrh-7fpw (node-tar- Denial of Service, CRITICAL, vulnerable<= 7.5.18). This is the only critical advisory in the tree, so it blocks the audit gate on every PR.After this override:
npm audit --audit-level=critical-> exit0(0 critical; the remaining 216 advisories are all low/moderate/high and pre-existing, unaffected by this change).GHSA-23hp-3jrh-7fpwno longer present.Runtime risk: low
Neither vulnerable
tarpath is on a request-serving runtime code path:swarm-js(tar@4) is unreachable dead code pulled in transitively viaweb3.node-pre-gyp(tar@6) only runs at install time to unpack the prebuiltbcryptbinary.The bump is a pure security-hygiene / CI-unblock change, confined entirely to the
tarsubtree.Scope / confinement
package.json: +1 line (one new entry in the pre-existingoverridesblock; no other override touched).package-lock.json: regenerated vianpm install(not hand-edited). Every changed entry is within thetardependency family only - the oldtar@4subtree underswarm-jscollapses away andtar@6upgrades totar@7.5.20;chownr 2->3,minizlib 2->3,fs-minipass -> @isaacs/fs-minipass,yallist -> 5. No unrelated package changed.Verification (Node 20)
npm audit --audit-level=critical-> exit0npm run build(nest build) -> exit0tsc --noEmit-> exit0$2b$hash), proving the install-time unpack path is unaffected.PR completeness