Skip to content

fix(storage): stabilize content verification scan race - #4408

Merged
TaprootFreak merged 1 commit into
developfrom
fix/storage-content-scan-race
Jul 27, 2026
Merged

fix(storage): stabilize content verification scan race#4408
TaprootFreak merged 1 commit into
developfrom
fix/storage-content-scan-race

Conversation

@TaprootFreak

Copy link
Copy Markdown
Collaborator

Summary

  • recheck only content-report keys that appear missing on the allegedly absent target after the non-atomic listings
  • rebuild the full metadata, size, and needs-hash classification from the rechecked target metadata
  • apply the same stabilization to report, hash fixpoint, and final gate paths without downloads, writes, overwrites, deletes, or an upload freeze
  • reject large one-sided-empty inventories before per-key requests while allowing the bounded first-object race

Verification

  • 59 targeted content-verification tests
  • TypeScript type-check
  • ESLint
  • Prettier check
  • git diff check

@TaprootFreak

Copy link
Copy Markdown
Collaborator Author

Review completed in 1 PR pass with 0 findings. The pre-PR review also completed in 1 pass. The change preserves full metadata, size, and needs-hash classification after target rechecks, applies the same logic to report, hash-fixpoint, and final-gate paths, and keeps large one-sided-empty inventories fail-closed before per-key requests. Local targeted tests, type-check, lint, formatting, and diff validation are green; CI is still running.

@TaprootFreak
TaprootFreak marked this pull request as ready for review July 27, 2026 16:33
@TaprootFreak
TaprootFreak merged commit 16c4223 into develop Jul 27, 2026
12 checks passed
@TaprootFreak
TaprootFreak deleted the fix/storage-content-scan-race branch July 27, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant