fix(gs): allow querying the custody order completion timestamp - #4422
Merged
Conversation
The column was added with the sZCHF saving position but never added to the debug allowlist, so the value date behind the interest calculation could not be inspected in operation.
Collaborator
Author
|
Zero findings after one review pass (conformance and logic in one, given the size of the change). Confirmed along the way: The two FK columns left out of scope ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
custody_order.completedAttoDebugAllowedColumns.Why
The column was introduced together with the sZCHF saving position (#4418) as the immutable value date the accrued-interest calculation runs on, but it was never added to the debug allowlist. A structured query against it fails with
Column 'completedAt' is not allowed on this table, which means neither the value date of an individual order nor the result of the migration's backfill can be inspected in operation.The column is a plain timestamp with no personal data — the same class as
createdandupdated, which are allowed on every table.Scope
Verified against the merge commit of #4418 that
completedAtis the only column that PR introduced: it is the sole new@Columnin the only entity file the commit touches. The sZCHF asset itself came in through a data migration into the existing table, not a schema change.Two further columns on this table are absent from the allowlist (
transactionRequestId,transactionId, both physical FK columns from pre-existing relations). They predate #4418 and are deliberately left untouched here — widening the allowlist beyond this regression is a separate decision.