019faf74 - Cover gs/db trigger rejection over HTTP - #4477
Merged
Conversation
TaprootFreak
force-pushed
the
fix/gs-db-trigger-review-followups
branch
2 times, most recently
from
July 29, 2026 20:59
addd73d to
bdf4e8a
Compare
TaprootFreak
force-pushed
the
fix/gs-db-trigger-review-followups
branch
from
July 29, 2026 21:07
bdf4e8a to
bc49f57
Compare
Collaborator
Author
|
Follow-up validation complete on signed commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #4476:
POST /gs/dbandPOST /gs/db/customthrough the realGsController, NestJS routing,ValidationPipe, guards, and HTTP exception mapping400 Trigger type is requiredresponse, audit log, and absence of both GS service callsWhy
The first review of #4476 correctly identified that its regression coverage called controller methods directly and used a wall-clock threshold. That proved the controller branch but did not pin the actual HTTP contract, and the timing assertion could be flaky under scheduler load.
This follow-up covers the production controller at the HTTP boundary and tests the synchronous ordering without relying on elapsed wall time.
Deliberate non-change
The review also suggested deleting the persisted
gsTriggerEnforcementrow. This PR does not do that: the repository's critical auditable-mutation rule forbids destructive deletion when the previous value would no longer be reconstructible from the database. #4476 already removed every runtime read and the schema registration, so the retained row is inert historical data rather than an active control.Validation
Validated on exact signed commit
bc49f57a25cf75876350ec3d96a3916c41e93cc7:Production smoke for merged #4476: 10/10 authenticated missing-trigger requests returned HTTP 400 with
Trigger type is requiredin 58–85 ms.