Skip to content

e710bc80 - Only reuse a personal IBAN whose bank still receives #4501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TaprootFreak merged 1 commit into from
Jul 30, 2026
Merged

e710bc80 - Only reuse a personal IBAN whose bank still receives #4501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/subdomains/supporting/bank/virtual-iban/__tests__/virtual-iban.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1377,7 +1377,11 @@ describe('VirtualIbanService', () => {
expect(yapealVibanProvider.reserveViban).not.toHaveBeenCalled();
});

it('getActiveForUserAndCurrency keeps the merge-base selection semantics without excluding Frick', async () => {
it('getActiveForUserAndCurrency only considers rows whose bank still receives', async () => {
// A customer can hold several active rows per currency - a retired Yapeal EUR IBAN next to a
// working Frick one. findOne has no ORDER BY, so without this filter the retired row can win,
// the caller sees "found, but the bank does not receive", and with no collection-account
// fallback left the request fails outright. That hit every holder of a retired Yapeal EUR IBAN.
jest.spyOn(virtualIbanRepo, 'findOne').mockResolvedValue(null);

await service.getActiveForUserAndCurrency(userData, 'CHF');
Expand All @@ -1386,6 +1390,7 @@ describe('VirtualIbanService', () => {
where: {
userData: { id: 7 },
currency: { name: 'CHF' },
bank: { receive: true },
active: true,
status: VirtualIbanStatus.ACTIVE,
},
Expand Down
7 changes: 7 additions & 0 deletions src/subdomains/supporting/bank/virtual-iban/virtual-iban.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,13 @@ export class VirtualIbanService {
where: {
userData: { id: userData.id },
currency: { name: currencyName },
// A customer can hold several active rows for one currency - e.g. an old Yapeal EUR IBAN
// alongside a newer Frick one. Rows whose bank no longer receives must not be returned: this
// is a findOne without an ORDER BY, so a retired row can win over a working one, and the
// caller then sees "IBAN found, bank does not receive" and gives up. Since the collection
// account is no longer a fallback, that surfaced as PersonalIbanIssuanceFailed for every
// customer holding a retired Yapeal EUR IBAN.
bank: { receive: true },
active: true,
status: VirtualIbanStatus.ACTIVE,
},
Expand Down