feat(gs): grant staff clearance to the Compliance and Debug accounts of one staff member - #4596
Merged
Merged
Conversation
|
…of one staff member
Blume1977
force-pushed
the
feat/gs-staff-clearance-compliance-debug
branch
from
August 3, 2026 07:32
b3158eb to
7192daf
Compare
TaprootFreak
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
STAFF_VERIFIED_NAME_395822(keyed by the one account id known at review time). No plaintext personal name lives in the repository.docs/staff-kyc-clearance.mdexactly: precondition is the NULL-total negation of the closing assertion, the update is coupled to aStaffVerifiedNameBackfillaudit row via a data-modifying CTE, and the postcondition asserts the clearance predicate per account rather than name equality.Why
Since #4572, staff clearance requires a populated
verifiedName. The backfills so far (#4574, #4590) covered three accounts; the two accounts here were not among them and still answer every elevated endpoint withSTAFF_KYC_REQUIRED— the entire Compliance tool andPOST /gs/debugincluded. Self-service KYC cannot repair the Compliance account: the KYC flow rejects Compliance-role accounts outright (#3577).Impact and deployment
STAFF_VERIFIED_NAME_395822must be live in the production deployment configuration before this PR is merged todevelop—auto-release-pr.yamlkeeps a release PR open continuously, sodevelopis the last point where the order can still be arranged.Checks
node --checkon the migrationnpm run format/ eslint /tsc --noEmitcleanMIGRATION_TEST_PGservice); sibling migration specs still passmigration-psql-check) passes