Skip to content

Refactoring for solving network dependencies #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpalm3r merged 5 commits into from
Mar 18, 2026
Merged

Refactoring for solving network dependencies #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4c813b7
Refactoring for solving soft dependencies
jpalm3r Mar 6, 2026
08258d0
Refactor imports and update type checks for NetworkModelResult
jpalm3r Mar 17, 2026
3765264
delete copilot context
jpalm3r Mar 17, 2026
5ad7b33
add network as optional dpeendency for pip users
jpalm3r Mar 17, 2026
43f0d4d
Addressing review comments.
jpalm3r Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ classifiers = [
"Topic :: Scientific/Engineering",
]

[project.optional-dependencies]
networks = ["mikeio1d", "networkx"]

[dependency-groups]
dev = ["pytest", "plotly >= 4.5", "ruff==0.6.2", "netCDF4", "dask"]

Expand Down
2 changes: 1 addition & 1 deletion src/modelskill/model/adapters/_res1d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
if TYPE_CHECKING:
from mikeio1d.result_network import ResultNode, ResultGridPoint, ResultReach

from ..network import NetworkNode, EdgeBreakPoint, NetworkEdge
from modelskill.network import NetworkNode, EdgeBreakPoint, NetworkEdge


def _simplify_res1d_colnames(node: ResultNode | ResultGridPoint) -> pd.DataFrame:
Expand Down
Loading
Loading