Merged
Conversation
…ion and improve workflow description
ecomodeller
requested changes
Mar 17, 2026
Member
ecomodeller
left a comment
ecomodeller
left a comment
There was a problem hiding this comment.
The network page is thorough and technically correct, but it reads more like a developer guide than a user guide. The rest of the user guide follows a consistent pattern, load a file, match, assess skill, with minimal boilerplate, and never exposes base classes or property decorators.
The network page should follow that same pattern.
Extending modelskill with other network formats is not relevant for the typical user, it feels like it belongs in a separate developer guide (which we don't have).
Similar to https://docs.xarray.dev/en/stable/internals/how-to-add-new-backend.html
ecomodeller
approved these changes
Mar 18, 2026
Member
ecomodeller
left a comment
ecomodeller
left a comment
There was a problem hiding this comment.
Nice! Only comment is to add the new classes to the api docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including a network specific to the modelskill docs. This new section is under Extensions.
This PR requires closing #612 first.