Skip to content

Import fix #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpalm3r merged 1 commit into from
Mar 18, 2026
Merged

Import fix #616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions tests/test_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@
import xarray as xr
import numpy as np
import modelskill as ms
from modelskill.network import (
Network,
from modelskill.model.network import (
NetworkModelResult,
NodeModelResult,
)
from modelskill.network import (
Network,
BasicNode,
BasicEdge,
)
Expand Down Expand Up @@ -245,15 +247,17 @@ def test_node_attrs(self, sample_node_data):
def test_multiple_nodes_returns_list_of_observations(self, multi_data):
"""Test that from_multiple returns a list of NodeObservation objects"""
obs_list = NodeObservation.from_multiple(
data=multi_data, nodes={123: "station_0", 456: "station_1", 789: "station_2"}
data=multi_data,
nodes={123: "station_0", 456: "station_1", 789: "station_2"},
)

assert len(obs_list) == 3
assert all(isinstance(obs, NodeObservation) for obs in obs_list)

def test_node_ids_are_assigned_correctly(self, multi_data):
obs_list = NodeObservation.from_multiple(
data=multi_data, nodes={123: "station_0", 456: "station_1", 789: "station_2"}
data=multi_data,
nodes={123: "station_0", 456: "station_1", 789: "station_2"},
)

assert obs_list[0].node == 123
Expand All @@ -262,7 +266,8 @@ def test_node_ids_are_assigned_correctly(self, multi_data):

def test_names_derived_from_column_names(self, multi_data):
obs_list = NodeObservation.from_multiple(
data=multi_data, nodes={123: "station_0", 456: "station_1", 789: "station_2"}
data=multi_data,
nodes={123: "station_0", 456: "station_1", 789: "station_2"},
)

assert obs_list[0].name == "station_0"
Expand Down
Loading