Clean up unused constants and unsupported protocol phases#2
Merged
Conversation
added 2 commits
March 11, 2026 07:58
COPY_BOTH is only used for streaming replication (walsender mode) which this library does not support. The half-close lifecycle was also incompletely modeled. Can be re-added properly if replication support is needed in the future.
These StrEnum classes were wrong-typed (str instead of bytes) and unused internally. The message registry and codec use byte literals directly. Tests that referenced them now use byte literals too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
COPY_BOTHphase andCopyBothResponsemessage.COPY_BOTHis only used for streaming replication (walsendermode) which this library does not support, and the half-close lifecycle was incompletely modeled.FrontendMessageTypeandBackendMessageTypeenums. They wereStrEnum(wrong type for a bytes protocol), unused internally, and not worth fixing since the registry and codec already usebyteliterals directly.