fix: support reverse-direction (ManyToOne) nested deep insert#37
Merged
Conversation
ProcessOneToMany now handles both directions: - Parent is Referenced side → sets FK on children (existing behavior) - Parent is Referencing side → creates child first, then sets FK on parent This fixes nested deep inserts like Calendar → CalendarRule → InnerCalendar where the inner relationship goes from the Referencing to the Referenced side. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the deep-insert implementation so OneToManyRelationshipMetadata relationships can be processed from either side, enabling nested deep inserts where the “parent” entity is actually on the referencing (many) side of the relationship (e.g., Calendar → CalendarRule → InnerCalendar).
Changes:
- Extend
DeepInsertProcessor.ProcessOneToManyto support reverse-direction deep insert by creating the referenced child first, then updating the parent lookup. - Add a regression test covering a nested deep insert that crosses a reverse-direction (ManyToOne) relationship.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Digitall.Dataverse.Testing.Tests/OrganizationRequests/CreateFakeDeepInsertTests.cs | Adds a test validating reverse-direction nested deep insert sets the FK on the referencing-side parent. |
| src/Digitall.Dataverse.Testing/OrganizationRequests/DeepInsertProcessor.cs | Adjusts one-to-many deep insert handling to support both referenced-side and referencing-side parents. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+82
to
+95
| else if (metadata.ReferencingEntity == parentLogicalName) | ||
| { | ||
| // Parent is the "many" side → create child first, then set FK on parent pointing to child | ||
| foreach (var child in children.Entities) | ||
| { | ||
| var childId = state.Create(child); | ||
| var childRef = new EntityReference(metadata.ReferencedEntity, childId); | ||
|
|
||
| foreach (var child in children.Entities) | ||
| var parentUpdate = new Entity(parentLogicalName, parentId) | ||
| { | ||
| [metadata.ReferencingAttribute] = childRef | ||
| }; | ||
| state.Update(parentUpdate); | ||
| } |
Qodana Community for .NET40 new problems were found
View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2026.1.0
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
A lookup attribute can only reference one record. The N:1 (reverse) branch now throws an InvalidArgument fault when multiple children are provided, preventing silent data loss where only the last child would be linked. Also validates that the child's logical name matches metadata.ReferencedEntity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🎉 This PR is included in version 1.1.0-beta.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProcessOneToMany now handles both directions:
This fixes nested deep inserts like Calendar → CalendarRule → InnerCalendar where the inner relationship goes from the Referencing to the Referenced side.