[Bug]: Transformation AditionnalParameters are escaped

[chaen]

Search before creating an issue

• I have searched existing issues and confirmed this is not a duplicate

Bug Description

The AdditionalParameters are now escaped when inserted, which causes them not to be interpreted properly when read

Before

| TransformationID | ParameterName  | ParameterValue                                                                                                                    
                                                                     | ParameterType |                                                                                  
+------------------+----------------+-----------------------------------------------------------------------------------------------------------------------------------
---------------------------------------------------------------------+---------------+                                                                                  
| 401068           | BkQuery        | {'ConfigName': 'LHCb', 'ConfigVersion': 'Collision26', 'ProcessingPass': '/Real Data', 'EventType': '94000000', 'FileType': 'RAW',
 'Visible': 'Yes', 'RunNumbers': 345408}                             | StringType    |                                                                                  
| 401068           | DestinationSEs | ['Tier1-Buffer']                                                                                                                                                                                       | StringType    |

Now

                                                                        
| TransformationID | ParameterName  | ParameterValue                                                                                                                    
                                                                     | ParameterType |                                                                                  
+------------------+----------------+-----------------------------------------------------------------------------------------------------------------------------------
---------------------------------------------------------------------+---------------+                                                                                  
| 403949           | BkQuery        | '{\'ConfigName\': \'LHCb\', \'ConfigVersion\': \'Collision24\', \'ProcessingPass\': \'/Real Data\', \'EventType\': \'95100000\', \'FileType\': \'RAW\', \'Visible\': \'Yes\', \'RunNumbers\': 295304}' | StringType    |
| 403949           | DestinationSEs | '[\'Tier1-Buffer\']'                          
                                                                     | StringType    |

Steps to Reproduce

No response

Expected Behavior

No response

Actual Behavior

No response

Environment

No response

Relevant Log Output

Additional Context

@sfayer if you have an idea for a quick fix, it would be great ! Otherwise I'll try to tackle it asap, as it currently blocks all LHCb data management

[sfayer]

There are a couple of references to escapeString left in TransformationDB: I tried to catch all of these, but they tend to sneak through the test suite. I suspect this will fix it, but don't have a transformation system to try it on myself.

Regards,
Simon

[chaen]

I started something here
#8700

[chaen]

Do I understand correctly that in your PR you are dropping entirely the escaping of the string ? Is that ok, or would you rather try to "cast it" correctly like I tried in my PR ?

[sfayer]

If escapeString was sufficient before, then the parameterised version should cope with the same inputs just the same without it... In this case I've just forgotten to remove it so we're getting double escaping when the value is returned.

I think everything was just a string or int before, so I'd worry that adding new types now might have knock-on effects for other bits of code (things using this must already be expecting just strings (or ints) back otherwise it wouldn't have worked).