[int] Parameterise SQL in AccountingDB

[sfayer]

Part of #8547.

This is probably the one I'm most worried about in the set as the AccountingSystem does a lot of custom SQL: I'm not convinced the test coverage here is very complete. Do you have any suggestion on how we can test it further? (Perhaps we could put it on certification or something like that?)

BEGINRELEASENOTES
*Accounting
FIX: Parameterise SQL in AccountingDB
ENDRELEASENOTES

[fstagni]

I'm not convinced the test coverage here is very complete.

You are over-estimating the test coverage for everything else... :)

Anyway, for the moment some tests are failing.

Do you have any suggestion on how we can test it further? (Perhaps we could put it on certification or something like that?)

That's always an option.

[sfayer]

I've fixed the tests: I looked with @marianne013 at testing on certification but we decided that was probably excessive in this instance.

I guess you want to queue this one after after #8677 ? I'll rebase it once that one is complete...

Regards,
Simon

[fstagni]

I guess you want to queue this one after after #8677 ? I'll rebase it once that one is complete...

Yes, that would simplify things. Mind reviewing that one?

[sfayer]

I've rebased this one now, so it's up to date with the recent AccountingDB changes (it's already behind the branch again due to other merges in the last 30 minutes, but shouldn't conflict).