Skip to content

[int] Drop extra escaping in TransformationDB #8698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fstagni merged 1 commit into from
Jul 13, 2026
+2 −14
Merged

[int] Drop extra escaping in TransformationDB #8698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions src/DIRAC/TransformationSystem/DB/TransformationDB.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,10 +533,6 @@ def __addAdditionalTransformationParameter(self, transID, paramName, paramValue,
res = self._update(req, args=(transID, paramName), conn=connection)
if not res["OK"]:
return res
res = self._escapeString(paramValue)
if not res["OK"]:
return S_ERROR("Failed to parse parameter value")
paramValue = res["Value"]
paramType = "StringType"
if isinstance(paramValue, int):
paramType = "IntType"
Expand Down Expand Up @@ -1158,10 +1154,6 @@ def deleteTransformationMetaQuery(self, transName, queryType, author="", connect
return res
connection = res["Value"]["Connection"]
transID = res["Value"]["TransformationID"]
res = self._escapeString(queryType)
if not res["OK"]:
return S_ERROR("Failed to parse the transformation query type")
queryType = res["Value"]
req = "DELETE FROM TransformationMetaQueries WHERE TransformationID=%s AND QueryType=%s"
res = self._update(req, args=(transID, queryType), conn=connection)
if not res["OK"]:
Expand All @@ -1186,13 +1178,9 @@ def getTransformationMetaQuery(self, transName, queryType, connection=False):
return res
connection = res["Value"]["Connection"]
transID = res["Value"]["TransformationID"]
res = self._escapeString(queryType)
if not res["OK"]:
return S_ERROR("Failed to parse the transformation query type")
queryType = res["Value"]
req = "SELECT MetaDataName,MetaDataValue,MetaDataType FROM TransformationMetaQueries"
req += f" WHERE TransformationID={transID} AND QueryType={queryType}"
res = self._query(req, conn=connection)
req += " WHERE TransformationID=%s AND QueryType=%s"
res = self._query(req, args=(transID, queryType), conn=connection)
if not res["OK"]:
return res
queryDict = {}
Expand Down
Loading