docs: stop publishing a maintainer's absolute home path - #105
Merged
Conversation
docs/plans/post-audit-gameplan.md carried a literal /home/<user>/... path in its pasteable session brief, so a tracked, published file named the maintainer's account. privacy_smoke does flag it, but only on the machine it belongs to: the check derives the account name from the local environment, and on a GitHub runner that is "runner", so CI has never had a reason to fail. The brief does not need an absolute path — the checkout location is whatever the reader's is. Found while running the pre-release gates for 0.5.0. One occurrence repo-wide; `git grep /home/` is now clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/plans/post-audit-gameplan.md:354carried a literal/home/<user>/Projects/platecliin its pasteable session brief — a tracked, published file naming the maintainer's account.Why CI never caught it:
privacy_smokederives the local account name from the environment. On a GitHub runner that resolves torunner, so the pattern only matches on the maintainer's own machine. The check is doing its job; it just cannot see this class of leak from CI. Worth remembering: a greenPrivacy smokein CI is not evidence that tracked files are free of someone's local paths.The brief does not need an absolute path — the checkout location is whatever the reader's is.
Found while running the pre-release gates for 0.5.0, which is why it is a separate PR: the release PR stays version-bump-plus-changelog, and 0.5.0 ships with this already in.