Make only approved algo when in FIPS mode#1577
Merged
Merged
Conversation
Contributor
|
This logic should be in https://github.com/DMTF/libspdm/blob/main/include/internal/libspdm_lib_config.h In addition https://github.com/DMTF/libspdm/blob/main/include/internal/libspdm_macro_check.h should check that at least one FIPS algorithm is supported. |
Fix the issue: DMTF#1260 The approved algo is listed at:https://nvlpubs.nist.gov/nistpubs/ SpecialPublications/NIST.SP.800-140Cr1.pdf Signed-off-by: Wenxing Hou <wenxing.hou@intel.com>
Wenxing-hou
force-pushed
the
only_approved_algo_in_FIPS
branch
from
424d92c to
d713965
Compare
Contributor
Author
Thanks. I have move the code to internal/libspdm_lib_config.h. |
steven-bellock
added
enhancement
steven-bellock
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: #1260
The approved algo is listed at: https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-140Cr1.pdf
Signed-off-by: Wenxing Hou wenxing.hou@intel.com