Add FIPS selftest and get_result_selftest#1647
Conversation
42683c0 to
cd2680e
Compare
|
for selftest location, please refer to #1406 (comment) |
ac78a4f to
9422b9d
Compare
|
Please add all sym, deterministic asym algo at first. |
|
This is enough as the first patch. I recommend, we review the design at first, then merge, then continue with rest key exchange or probabilistic algo. |
9422b9d to
e462eb0
Compare
e462eb0 to
72a80f6
Compare
951f9d4 to
cc613fa
Compare
steven-bellock
left a comment
There was a problem hiding this comment.
@jyao1 Is this level of granularity ok? For example, if SHA-256 passes but SHA-384 fails, would you like to know that information? Or is any failure deemed fatal?
There was a problem hiding this comment.
Only list the algorithms that will be covered. For example SPDM doesn't support SHA1.
There was a problem hiding this comment.
Thanks. I have made the comments more clear.
There was a problem hiding this comment.
You can get rid of the explicit array sizes.
There was a problem hiding this comment.
Yes. I deleted all explicit array sizes.
There was a problem hiding this comment.
For C89 compatibility we don't allow procedural statements until all variables have been declared for a scope. So I would make this bool result = true;.
There was a problem hiding this comment.
Thanks. I will remember it.
cc613fa to
20e44fb
Compare
20e44fb to
3aeaef1
Compare
reference: #1260
Commit 1: Add HMAC self_test;
Commit 2: Add AES_GCM self_test;
Commit 3: Add RSA_SSA self_test;
When the LIBSPDM_FIPS_MODE is open, the test result:

When the LIBSPDM_FIPS_MODE is closed, the test result:

Signed-off-by: Wenxing Hou wenxing.hou@intel.com