Add sha3 self_test#1687
Merged
Merged
Conversation
jyao1
reviewed
Feb 3, 2023
Member
There was a problem hiding this comment.
using crypto specific macro is not right way
Contributor
Author
There was a problem hiding this comment.
Yes. I will remember that. Thanks.
Wenxing-hou
force-pushed
the
Add_sha3_self_test
branch
from
1f1ab0e to
71fb3ec
Compare
Reference: DMTF#1260 For openssl, sha3 self_test is passed. For mbedtls, sha3 self_test just return ture: because mbedtsl doesn't support sha3 in libspdm now. Signed-off-by: Wenxing Hou <wenxing.hou@intel.com>
Wenxing-hou
force-pushed
the
Add_sha3_self_test
branch
from
71fb3ec to
7bb0771
Compare
jyao1
approved these changes
Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: #1260
For openssl, sha3 self_test is passed.
For mbedtls, sha3 self_test just return ture: because mbedtsl doesn't support sha3 in libspdm now.
Signed-off-by: Wenxing Hou wenxing.hou@intel.com