Conversation
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
Contributor
Member
Author
|
I cannot know if it will truly fix. I just know this is a bug that will cause the test failure, because there is a minor chance that the key will have leading bytes 0 and cause the final key length to be shorter. |
steven-bellock
approved these changes
Apr 14, 2026
Contributor
steven-bellock
left a comment
steven-bellock
left a comment
There was a problem hiding this comment.
Ok. We will need to keep an eye on intermittent test failures still.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3557
SPDM spec requires to follow section 7.4 of RFC 8446 defines.
RFC 8446 requires fixed-length unsigned integer in the byte order of the group size (padded with zeros on the left).