unit_test/test_crypt: Guard EdDSA tests per-algorithm#3632
Merged
Conversation
The Ed-DSA signing test and the EdDSA X.509 test were guarded by the combined (LIBSPDM_EDDSA_ED25519_SUPPORT || LIBSPDM_EDDSA_ED448_SUPPORT) condition but then exercised both Ed25519 and Ed448 unconditionally. A backend that supports only one curve would therefore fail on the unsupported curve. Guard each curve by its own LIBSPDM_EDDSA_ED25519_SUPPORT / LIBSPDM_EDDSA_ED448_SUPPORT macro so the test runs whichever curve(s) the crypto backend actually supports. Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ed-DSA signing test and the EdDSA X.509 test were guarded by the combined (LIBSPDM_EDDSA_ED25519_SUPPORT || LIBSPDM_EDDSA_ED448_SUPPORT) condition but then exercised both Ed25519 and Ed448 unconditionally. A backend that supports only one curve would therefore fail on the unsupported curve.
Guard each curve by its own LIBSPDM_EDDSA_ED25519_SUPPORT / LIBSPDM_EDDSA_ED448_SUPPORT macro so the test runs whichever curve(s) the crypto backend actually supports.