Add possibility to provide headers for login requests#173
Merged
Add possibility to provide headers for login requests#173
Conversation
Signed-off-by: Benny Fuhry <benny@cheffu.de>
BFuhry
force-pushed
the
bfuhry/loginHeaders
branch
from
343e1c3 to
5358981
Compare
mraineri
reviewed
Mar 5, 2025
Signed-off-by: Benny Fuhry <benny@cheffu.de>
Contributor
|
Looks good on my end! We'll have a wider review later this week for formal acceptance |
Contributor
|
Approved 3/7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A generic change allowing to set arbitrary headers on the login request, which is already supported by, e.g.,
get,head, andpost.In my case, I want to access a RedFish endpoint, which is only reachable using local port forwarding. In such a situation, the authentication requests leads to a
Base.1.12.AccessDenied. Presumably because the request is forlocalhost:<forward port>instead of<bmc ip>:<bmc port>. This can be resolved by setting theHostHTTP header to<bmc ip>, which I can easily do with the proposed change.