Fix propagating headers across different class instances#179
Merged
Fix propagating headers across different class instances#179
Conversation
There was a bug in login function of RestClientBase which incorrectly
propagated headers across all instances of the class. Fix it.
The empty dictionary was created only once in the parameter list, and
then reused for all following instances.
The bug appears e.g. when trying to change the authorization method
in the same service using redfish library:
1) creating redfish_client with basic authorization adds a header
to a global headers dictionary ('Authorization')
2) creating a totally separate instance of redfish_client with
session fails, because we get unexpected 'Authorization'
header which was created in previous instance and propagated
incorrectly
Simplified example to explain the incorrect use of dictionary parameter:
```
class Example:
def bad_param(self, optional_dict={}):
if not optional_dict:
print('Optional dict is empty, adding something')
optional_dict['some'] = 'thing'
else:
print(f'Optional dict is NOT empty: {optional_dict}')
example1 = Example()
example1.bad_param()
example2 = Example()
example2.bad_param()
```
Signed-off-by: Michał Michalik <michal.michalik.priv@gmail.com>
Contributor
|
Approved 6/27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in login function of RestClientBase which incorrectly propagated headers across all instances of the class. Fix it.
The empty dictionary was created only once in the parameter list, and then reused for all following instances.
The bug appears e.g. when trying to change the authorization method in the same service using redfish library:
to a global headers dictionary ('Authorization')
session fails, because we get unexpected 'Authorization'
header which was created in previous instance and propagated
incorrectly
Simplified example to explain the incorrect use of dictionary parameter:
Signed-off-by: Michał Michalik michal.michalik.priv@gmail.com