[CU-86baqy91f] Remove deprecated X-Admin-Only-Action header (send only X-Global-Namespace)#182
Merged
Conversation
…y X-Global-Namespace) The dual-header (CU-86baju3x7) sent both X-Global-Namespace and the legacy X-Admin-Only-Action so the CLI worked against workbench services on either side of the header refactor. Fine-grained enforcement is now on everywhere and workflow-service no longer reads the legacy header (Phase 3), so the backward-compat leg is dead. Drop it so global/admin workflow ops send only X-Global-Namespace. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
angelo-DNAStack
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The CLI's dual-header (CU-86baju3x7) sent both
X-Global-Namespaceand the legacyX-Admin-Only-Actionso it worked against workbench services on either side of the header refactor. Fine-grained enforcement is now on everywhere and workflow-service no longer reads the legacy header (Phase 3 — workflow-service #167), so the backward-compat leg is dead. CLI analog of the services' Phase 3. (CU-86baqy91f)What
workflow/client.py:_GLOBAL_NAMESPACE_HEADERS→{'X-Global-Namespace': 'true'}(dropX-Admin-Only-Action). The 15 global/admin workflow ops that.update(_GLOBAL_NAMESPACE_HEADERS)now send onlyX-Global-Namespace.test_workflow_client_admin_header.py: drop the dual-header assertion and the legacy-absence assertion.Zero
X-Admin-Only-Actionreferences remain in the repo (code + tests).Testing
ruff checkclean; the 13 header unit tests pass. The e2e criterion (a global workflow op against alpha with fine-grained enforcement ON) runs in CI.Sequencing: safe to ship — the prerequisite CU-86baqpzv7 (enforcement enabled everywhere; services ignore the legacy header) is complete.