Skip to content

Minor cleanup#1822

Merged
jedisct1 merged 3 commits intoDNSCrypt:masterfrom
a1346054:master
Aug 18, 2021
Merged

Minor cleanup#1822
jedisct1 merged 3 commits intoDNSCrypt:masterfrom
a1346054:master

Conversation

@a1346054
Copy link
Copy Markdown
Contributor

Most importantly, make sure github (and everyone else) recognizes the license properly as ISC license.

@jedisct1
Copy link
Copy Markdown
Member

Thank you!

The space after #! is intentional, though. I would really like to keep it that way.

Old unix junkies may know why :)

@a1346054
Copy link
Copy Markdown
Contributor Author

Understood, it is a matter of personal preference.

I did however do a scan of all script files in my $PATH and checked if the first line begins with #!/ or #! / and the vast majority of them are #!/ by now. So wanted to unify the rest.

You can pick the other commits from the pull request, or I can revert that one commit, or rebase it completely. Up to you.

For me, the most important part is having the proper license file, because that's what was preventing the use of dnscrypt-proxy at $dayjob... really...

@a1346054
Copy link
Copy Markdown
Contributor Author

Rebased without the #! changes.

@jedisct1 jedisct1 merged commit f6a2d2e into DNSCrypt:master Aug 18, 2021
@DNSCrypt DNSCrypt locked and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants