Skip to content

ci-test.sh: show line number where failed#3034

Merged
jedisct1 merged 1 commit intoDNSCrypt:masterfrom
lifenjoiner:test
Nov 14, 2025
Merged

ci-test.sh: show line number where failed#3034
jedisct1 merged 1 commit intoDNSCrypt:masterfrom
lifenjoiner:test

Conversation

@lifenjoiner
Copy link
Copy Markdown
Member

Easier to locate the failed test.

@jedisct1
Copy link
Copy Markdown
Member

Never heard about $caller. It that specific to some shell?

@welwood08
Copy link
Copy Markdown
Contributor

I believe caller (not $caller) is a Bash builtin command. Whilst it looks useful, I don't think it's appropriate to assume it exists in a POSIX sh script.

@lifenjoiner
Copy link
Copy Markdown
Member Author

I only have msys2. Shall we use $LINENO as an argument to fail()?

@lifenjoiner
Copy link
Copy Markdown
Member Author

Updated to use $LINENO for compatibility.

@jedisct1 jedisct1 merged commit ad9c81e into DNSCrypt:master Nov 14, 2025
1 check passed
@lifenjoiner lifenjoiner deleted the test branch November 15, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants