You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ensure both Samples CSV getters preserve code and identifier columns as text, including zero-padded parameter codes, hydrologic-unit codes, FIPS codes, and monitoring-location and organization identifiers. Measurement and count columns must retain their appropriate numeric types.
Use one shared response-parsing convention for Samples and WQP rather than importing one adapter from another or duplicating identifier detection. Preserve all existing getter signatures, return shapes, metadata, datetime shaping, and request behavior. Document the intentional dtype correction in the release notes.
Acceptance criteria
Both Samples getters return identifier and code columns as strings without dropping leading zeros.
Numeric measurement and count columns remain numeric.
Code-column detection and the two-pass CSV parse have one shared implementation used by Samples and WQP.
Existing WQP parsing behavior is unchanged and protected by its leading-zero regression coverage.
Offline tests cover zero-padded parameter, HUC, and FIPS values through the public Samples getters, including the summary path.
Public APIs, request URLs, metadata, frame columns, datetime shaping, and sort behavior are unchanged apart from corrected dtypes.
The full offline suite, coverage gate, type checker, linter, architecture tests, and dependency contracts pass.
What to build
Ensure both Samples CSV getters preserve code and identifier columns as text, including zero-padded parameter codes, hydrologic-unit codes, FIPS codes, and monitoring-location and organization identifiers. Measurement and count columns must retain their appropriate numeric types.
Use one shared response-parsing convention for Samples and WQP rather than importing one adapter from another or duplicating identifier detection. Preserve all existing getter signatures, return shapes, metadata, datetime shaping, and request behavior. Document the intentional dtype correction in the release notes.
Acceptance criteria
Blocked by
None — can start immediately.