Add option to specify priority for rejudgings. #1040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1040 +/- ##
============================================
- Coverage 36.62% 36.61% -0.02%
- Complexity 5347 5351 +4
============================================
Files 249 249
Lines 19176 19188 +12
============================================
+ Hits 7024 7025 +1
- Misses 12152 12163 +11
Continue to review full report at Codecov.
|
| $builder->add('priority', ChoiceType::class, | ||
| [ | ||
| 'choices' => [ | ||
| 'low' => 'low', |
Member
There was a problem hiding this comment.
Why not set the keys (or values, I always forget) to the actual prio numbers? Symfony will validate you actually pass a valid value so you can’t “hack” the form and specify something else (well technically because we have the Ajax in between you could but 🤷♂️)
Member
Author
There was a problem hiding this comment.
You could also use curl or httpie, and I don't want to accept arbitrary priorities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #639.