Skip to content

Conversation

@meisterT
Copy link
Member

Looks like they had a release today and that might be the reason for our test failures.

Looks like they had a release today and that might be the reason for our
test failures.
@vmcj
Copy link
Member

vmcj commented Oct 24, 2025

I rather not pin as they seemed to not release often so it's more of a hassle to check manually

@meisterT
Copy link
Member Author

IMO, pinning versions is best practice to avoid errors like this one.

But I will not fight for it if you dislike pinning. However, let's be pragmatic and merge this PR and then separately fix whatever changed at HEAD so that other PRs can be merged in the meantime.

@meisterT meisterT added this pull request to the merge queue Oct 24, 2025
Merged via the queue into DOMjudge:main with commit 5782543 Oct 24, 2025
36 checks passed
@meisterT meisterT deleted the vnupin branch October 24, 2025 17:57
@vmcj
Copy link
Member

vmcj commented Oct 24, 2025

IMO, pinning versions is best practice to avoid errors like this one.

But I will not fight for it if you dislike pinning. However, let's be pragmatic and merge this PR and then separately fix whatever changed at HEAD so that other PRs can be merged in the meantime.

I think for components which upgrade often pinning is fine as I tend to check those often and upgrade them when needed. IRC this component does not often so I rather accept a day like today where we need to fix CI instead of having the check often with no new release. Especially for VNU I hope they finally implemented the current "accepted" spec for some elements so we can remove a couple of warnings as it tends to be very conservative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants