Reencode submission source in UTF-8 when displaying in monaco #3221
Conversation
vmcj
left a comment
vmcj
left a comment
There was a problem hiding this comment.
Let's discuss this in person, this might be a proper fix but I'm not sure if we should change submissions for participants (out of principle)
So mostly blocking merging now.
|
This is not changing submissions. It is changing the display of submissions. The submissions it changes would not be displayed previously, see bug and screenshot |
1 similar comment
|
This is not changing submissions. It is changing the display of submissions. The submissions it changes would not be displayed previously, see bug and screenshot |
Kevinjil
changed the title
As we'll meet this week anyway, I don't see a reason not to discuss in person so I'll wait with merging. |
Wrongly read this as that we do this on import. |
|
I'll postpone merging this until after a small in-person discussion about #3217 (comment) |
Kevinjil
force-pushed
the
reencode-utf8
branch
2 times, most recently
from
e2e68fc to
4c25407
Compare
Kevinjil
force-pushed
the
reencode-utf8
branch
3 times, most recently
from
15145f6 to
7fda4e8
Compare
Try to re-encode the submission source if it currently is not valid in UTF-8. Add some extra safeguard by forcing another sanity check re-encode from UTF-8 to the original encoding, which filters out binary blobs and verifies that the re-encoding is non-destructive.
Kevinjil
force-pushed
the
reencode-utf8
branch
from
7fda4e8 to
224dc7e
Compare
4 participants
Try to reencode the submission source if it currently is not valid in UTF-8. Add some extra safeguard by forcing another sanity check reencode from UTF-8 to UTF-8, which filters out binary blobs.
Before:
After:
Blobs still filtered out:
Fixes #3217