Use external ID in UI everywhere instead of internal database ID #3263

nickygerritsen · 2025-11-30T08:49:10Z

Fixes #3024

Part of DOMjudge#3024

…internal IDs Part of DOMjudge#3024

Part of DOMjudge#3024

…al IDs Part of DOMjudge#3024

Part of DOMjudge#3024

…al IDs Part of DOMjudge#3024

…nal IDs Part of DOMjudge#3024

Part of DOMjudge#3024

Part of DOMjudge#3024 # Conflicts: # webapp/templates/jury/partials/submission_diff.html.twig # webapp/templates/jury/submission_source.html.twig

…nstead of internal IDs Part of DOMjudge#3024

Part of DOMjudge#3024

Part of DOMjudge#3024 � Conflicts: � judge/judgedaemon.main.php

Part of DOMjudge#3024

meisterT · 2025-12-01T17:54:47Z

judge/judgedaemon.main.php

    private function judgingDirectory(string $workdirpath, array $judgeTask): string
    {
-        if (filter_var($judgeTask['submitid'], FILTER_VALIDATE_INT) === false ||
+        if (filter_var($judgeTask['submitid'], FILTER_VALIDATE_REGEXP, ['options' => ['regexp' => '/^[a-zA-Z0-9_.-]+$/']]) === false ||


should we define this somewhere more generally?

Also, what do submission URLs look like after this change?

What are you suggesting for generally defining this? The judgedaemon doesn't have access to the Symfony code.

As for urls, it's https://domjudge/jury/submissions/[id] still, but the [id] can be a string (although if we generate submission ID's they will actually be numbers, only when external systems generate them they will be strings).

meisterT · 2025-12-01T17:56:33Z

webapp/migrations/Version20251024122021.php

+        $this->addSql('ALTER TABLE version ADD langid_str VARCHAR(32) DEFAULT NULL AFTER langid');
+
+        $this->addSql("UPDATE language SET langid_str = CASE externalid
+            WHEN 'ada' THEN 'adb'


huh, ada -> adb? Is that what you want?

Yes, we used adb as langid for ADA files, but the CLICS spec uses ada.

meisterT · 2025-12-01T17:58:25Z

webapp/src/Controller/Jury/ClarificationController.php

+                $data['subjectlink'] = $this->generateUrl('jury_problem', ['probId' => $clar->getProblem()->getExternalid()]);
            } elseif ($clar->getCategory()) {
-                $concernssubject = $contest->getCid() . "-" . $clar->getCategory();
+                $concernssubject = $contest->getExternalid() . "#" . $clar->getCategory();


why not also use |?

Because then you can't have a problem with the same ID as a clarification category

meisterT · 2025-12-01T17:59:59Z

webapp/src/Controller/Jury/TeamAffiliationController.php


    #[IsGranted('ROLE_ADMIN')]
-    #[Route(path: '/delete-multiple', name: 'jury_team_affiliation_delete_multiple', methods: ['GET', 'POST'])]
+    #[Route(path: '/delete-multiple', name: 'jury_team_affiliation_delete_multiple', methods: ['GET', 'POST'], priority: 1)]


what does priority: 1 mean/do here?

It makes it that jury/affiliations/delete-multiple goes to this route and not suggests you want to view the affiliation called delete-multiple. In the past we reordered the methods to have this come earlier than the view action, but I like this way more.

meisterT · 2025-12-01T18:00:55Z

webapp/src/Controller/BaseController.php

+     *
+     * @return array{previous: string|int|null, next: string|int|null}
+     */
+    protected function getPreviousAndNextObjectIds(


Is it easy to add a few unit tests for this method?

I will try, I think that makes sense.

meisterT · 2025-12-01T18:02:30Z

webapp/templates/jury/analysis/contest_overview.html.twig

            <tbody>
            {% for p in problems %}
-              {% set id=p.probid %}
+              {% set id=p.externalId %}


looking at all these places, should we just use p.id or p.probid to mean the external id and p.internalId to mean the probid? Could be done separately though

I wonder if that is better. It will have less changes in the twigs but then have other changes instead. Not sure I actually like it, but we can try it separately indeed.

meisterT · 2025-12-01T18:03:16Z

ChangeLog

This might deserve a changelog entry :-)

nickygerritsen added 30 commits November 30, 2025 09:43

Change language.langid to auto increment integer

821b1b8

Part of DOMjudge#3024

Change public pages to use external IDs instead of internal IDs

64de025

Part of DOMjudge#3024

Change team pages to use external IDs instead of internal IDs

31b5d06

Part of DOMjudge#3024

Change jury analysis pages to use external IDs instead of internal IDs

f09e488

Part of DOMjudge#3024

Change jury audit log pages and logic to use external IDs instead of …

6371dc7

…internal IDs Part of DOMjudge#3024

Change jury balloon pages to use external IDs instead of internal IDs

3c8895d

Part of DOMjudge#3024

Change jury clarification pages to use external IDs instead of intern…

75e1799

…al IDs Part of DOMjudge#3024

Change config checker to use external IDs instead of internal IDs

fefba55

Part of DOMjudge#3024

Change jury contest pages to use external IDs instead of internal IDs

ea354b6

Part of DOMjudge#3024

Change jury executable pages to use external IDs instead of internal IDs

2c22819

Part of DOMjudge#3024

Update entity ID badge to display only one ID

d01e393

Part of DOMjudge#3024

Fix refreshing scoreboard with external IDs

e1970f3

Part of DOMjudge#3024

Change jury import/export pages to use external IDs instead of intern…

b510a51

…al IDs Part of DOMjudge#3024

Change jury internal error pages to use external IDs instead of inter…

7fb7b92

…nal IDs Part of DOMjudge#3024

Fix freeze display for balloons page with external ID

15fccb6

Part of DOMjudge#3024

Change jury misc pages to use external IDs instead of internal IDs

5222b7a

Part of DOMjudge#3024

Make sure we save the audit log with a string

b3f4661

Part of DOMjudge#3024

Change jury language pages to use external IDs instead of internal IDs

1a12659

Part of DOMjudge#3024

Change jury problem pages to use external IDs instead of internal IDs

38f2975

Part of DOMjudge#3024

Change jury queue task pages to use external IDs instead of internal IDs

6702b9c

Part of DOMjudge#3024

Change jury rejudging pages to use external IDs instead of internal IDs

d590c34

Part of DOMjudge#3024

Change jury scoreboard page to use external IDs instead of internal IDs

02bd5cb

Part of DOMjudge#3024

Change jury submission pages to use external IDs instead of internal IDs

2d9333d

Part of DOMjudge#3024 # Conflicts: # webapp/templates/jury/partials/submission_diff.html.twig # webapp/templates/jury/submission_source.html.twig

Change jury team affiliation and category pages to use external IDs i…

dd0d6dd

…nstead of internal IDs Part of DOMjudge#3024

Change jury team pages to use external IDs instead of internal IDs

928befb

Part of DOMjudge#3024

Change jury user pages to use external IDs instead of internal IDs

c2121c5

Part of DOMjudge#3024

Make keyboard shortcuts work with external IDs

2a97bfd

Part of DOMjudge#3024

Do not expose internal IDs in public API

7368c00

Part of DOMjudge#3024

Use external submission ID in judgehost API

290fa58

Part of DOMjudge#3024 � Conflicts: � judge/judgedaemon.main.php

Fix tests to be in sync with external ID changes

13b1945

Part of DOMjudge#3024

nickygerritsen added 2 commits November 30, 2025 09:55

Fix spelling errors

3960c35

Fix one final test

7ff7b0b

meisterT reviewed Dec 1, 2025

View reviewed changes

Use external ID in UI everywhere instead of internal database ID #3263

Are you sure you want to change the base?

Use external ID in UI everywhere instead of internal database ID #3263

Uh oh!

Conversation

nickygerritsen commented Nov 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickygerritsen Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickygerritsen Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nickygerritsen Dec 4, 2025 •

edited

Loading

nickygerritsen Dec 4, 2025 •

edited

Loading