Skip to content

Defence in depth for adding directories to the zip #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vmcj wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Defence in depth for adding directories to the zip #3309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions webapp/src/Service/DOMJudgeService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1574,6 +1574,10 @@ public function getScoreboardZip(
if ($filepath === false) {
throw new Exception("Could not find (possibly symlinked) file: " . $file . ", at: " . $publicPath);
}
if (!in_array(filetype($filepath), ['file', 'link'])) {
// Ignore special filetypes
continue;
}
if (!(str_starts_with($filepath, $publicPath) ||
str_starts_with($filepath, $this->vendorDir) ||
str_starts_with($filepath, $this->nodeModulesDir))
Expand Down
Loading