Conversation
…date PR template Update copilot-instructions.md with comprehensive Crove OS standards, clean up PR template, rename eslint workflow to eslint.yml with Node 22, remove redundant build-deploy workflow, and optimize stale issue schedule.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_c3303eb5-10da-4a0b-bd77-0baafe2db076) |
There was a problem hiding this comment.
Code Review
This pull request updates the repository's GitHub configuration files, specifically modernizing the pull request template and completely rewriting the Copilot instructions to align with the Crove Post architecture, detailing its monorepo structure, core backend/frontend principles, and developer workflows. The review feedback highlights two key improvements: moving the change-type checkboxes in the PR template out of HTML comments so they render interactively, and correcting the Next.js version reference in the Copilot instructions from 16 to 15 to accurately reflect React 19 compatibility.
| # What kind of change does this PR introduce? | ||
|
|
||
| eg: Bug fix, feature, docs update, ... | ||
| <!-- [ ] Bug fix | [ ] Feature | [ ] Architecture & Docs | [ ] Refactor | [ ] CI/CD --> |
There was a problem hiding this comment.
Placing the checkboxes inside an HTML comment prevents them from being rendered and interactively checked in the GitHub pull request UI. Move them out of the comment and format them as a standard list of markdown checkboxes so authors can easily select the change type.
| <!-- [ ] Bug fix | [ ] Feature | [ ] Architecture & Docs | [ ] Refactor | [ ] CI/CD --> | |
| - [ ] Bug fix | |
| - [ ] Feature | |
| - [ ] Architecture & Docs | |
| - [ ] Refactor | |
| - [ ] CI/CD |
| }); | ||
| ``` | ||
| ## 4. Frontend & UI Guidelines | ||
| - Framework: Next.js 16 App Router with React 19. |
There was a problem hiding this comment.
What kind of change does this PR introduce?
CI/CD & AI Reviewer Standardization
Why was this change needed?
Streamlines and standardizes open-source GitHub Actions workflows and AI reviewer instructions:
copilot-instructions.md): Updated with comprehensive Crove OS standards (Monorepo with PNPM, Node 22, NestJS, Next.js 16 App Router + React 19, Multi-schemapostPostgreSQL, 2-Tier Sync, Mastra MCP tools with aliasing).PULL_REQUEST_TEMPLATE.md): Cleaned up legacy upstream contribution text and non-AI checkboxes..github/workflows/eslintto.github/workflows/eslint.ymlwith Node 22 & PNPM support.build-deploy-crove.yml(multi-arch packaging is consolidated inbuild-containers.yml).stale.ymlto run weekly onDOS/Crove-Postinstead of every 30 minutes on upstream repository.codeql.yml,build.yml, andbranding-guard.ymltriggers to cover bothmainanddevbranches and PRs.Checklist:
pnpm run build).pnpm dlx tsx scripts/branding-guard.ts).Note
Low Risk
Changes are limited to GitHub templates and Actions; the main operational note is ensuring container publish/deploy still runs after removing
build-deploy-crove.yml.Overview
Aligns GitHub contributor and CI metadata with Crove Post instead of upstream Postiz: the PR template drops legacy contribution/CLA/AI-attestation items and adds Crove-focused sections (technical scope, verification) plus a checklist for build, branding guard, and secrets.
Rewrites
.github/copilot-instructions.mdfor Crove OS (Node 22, PNPM, NestJS layering, DOS ID SSO, webhooks/MCP) and removes the prior Postiz-oriented overview and Sentry logging guidance.CI workflow changes:
mainanddev(and PRs) are wired into build, branding-guard, CodeQL, and ESLint; Node 22 and pnpm/action-setup@v4 are standardized; ESLint runs via pnpm with softer failure handling (|| true/continue-on-error). Branding guard now installs deps beforetsx.build-deploy-crove.ymlis deleted (image build/deploy logic expected elsewhere, e.g.build-containers.yml).build.ymldropsmerge_group, addsworkflow_dispatch, and simplifies install steps.Stale bot targets
DOS/Crove-Post, runs weekly (not every 30 minutes), and uses updated stale/close windows and exempt labels.Reviewed by Cursor Bugbot for commit fa4ac4c. Configure here.