Skip to content

Harden Testnet BENS deployment startup - #179

Merged
JOY (JOY) merged 5 commits into
mainfrom
codex/ensv2-bens-config-permissions
Aug 12, 2026
Merged

Harden Testnet BENS deployment startup#179
JOY (JOY) merged 5 commits into
mainfrom
codex/ensv2-bens-config-permissions

Conversation

@JOY

Copy link
Copy Markdown

What changed

  • make the deployed BENS directory traversable and the generated runtime config readable by the official non-root BENS image user
  • detect whether Graph Node actually activates the subgraph after Graph CLI returns
  • retry transient Graph admin deployment failures with the already uploaded immutable IPFS hash
  • add regression assertions for both production-runtime failure modes

Root cause

Run 31622196197 exposed two independent first-deploy failures. Graph CLI received an ECONNRESET while Graph Node was activating the uploaded subgraph, leaving no active version. The deployment archive was extracted under umask 077, and cp -a preserved a mode-0700 BENS directory, so the official BENS image user could not read config.json.

Validation

  • python -m unittest discover -s .github/scripts/tests -p 'test_*.py' - 24 passed
  • python scripts/validate-testnet-bens.py
  • actionlint.exe .github/workflows/deploy-config.yml .github/workflows/dependency-build.yml
  • docker compose ... config -q
  • rendered deployer command validated with Alpine /bin/sh -n
  • git diff --check
  • failed deployment rollback verified healthy locally and through https://test.doscan.io/api/v2/stats

@JOY
JOY (JOY) marked this pull request as ready for review August 12, 2026 17:47
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a retry mechanism for deploying the dos-names subgraph in the testnet environment, including health checks to verify subgraph readiness and extraction of the IPFS hash for retry attempts. It also adds corresponding test coverage. The review feedback suggests improving test robustness by asserting the presence of the delimiter string before splitting the workflow file, and refining the regular expression used to extract the subgraph IPFS hash to avoid capturing intermediate file hashes.

Comment thread .github/scripts/tests/test_validate_testnet_bens.py
Comment thread docker-compose/docker-compose-testnet.yml Outdated
@JOY
JOY (JOY) merged commit e580468 into main Aug 12, 2026
12 checks passed
@JOY
JOY (JOY) deleted the codex/ensv2-bens-config-permissions branch August 12, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant