Skip to content

modules: remove some zombie symbols - #555

Merged
rjarry merged 1 commit into
DPDK:mainfrom
david-marchand:zombies
Mar 16, 2026
Merged

modules: remove some zombie symbols#555
rjarry merged 1 commit into
DPDK:mainfrom
david-marchand:zombies

Conversation

@david-marchand

@david-marchand david-marchand commented Mar 16, 2026

Copy link
Copy Markdown
Member

port_get_rxq_buffer_us and port_allmulti_set declarations were left behind after dropping their implementation.

Fixes: f371a5e ("port: use interrupt thread to monitor link status and speed")
Fixes: ec4cbdc ("port: always enable allmulti and simplify MAC filtering")

Summary by CodeRabbit

  • Refactor
    • Removed internal port buffer and multicast configuration APIs; these were private/internal interfaces.
    • No visible end-user UI or behavior changes expected; internal integrations or extensions relying on those private APIs may need adjustment.

@coderabbitai

coderabbitai Bot commented Mar 16, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b27d667e-a72b-451f-af5c-bc77f19c7233

📥 Commits

Reviewing files that changed from the base of the PR and between c70c36d and 75d6c7b.

📒 Files selected for processing (2)
  • modules/infra/control/gr_port.h
  • modules/infra/control/port_priv.h

📝 Walkthrough

Walkthrough

This pull request removes two public function declarations: port_get_rxq_buffer_us(uint16_t port_id, uint16_t rxq_id) from modules/infra/control/gr_port.h and port_allmulti_set(struct iface *, bool enabled) from modules/infra/control/port_priv.h. Each change is a single-line deletion from its respective header; no other prototypes or declarations in those files were modified.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

port_get_rxq_buffer_us and port_allmulti_set declarations were left behind
after dropping their implementation.

Fixes: ec4cbdc ("port: always enable allmulti and simplify MAC filtering")
Fixes: f371a5e ("port: use interrupt thread to monitor link status and speed")
Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Robin Jarry <rjarry@redhat.com>
@rjarry
rjarry merged commit e57a8e9 into DPDK:main Mar 16, 2026
6 checks passed
@david-marchand
david-marchand deleted the zombies branch March 16, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants