[ci] Restore PR-only formula gate, document why - #2
Merged
Conversation
Reverts the previous commit's premise. test-bot selects formulae by diffing HEAD against origin/main, so on a push to main the diff is empty and --only-formulae reports green having tested (none) — verified on two consecutive pushes, including one that changed tailctl.rb. Running it on push therefore cannot work. The gate has to be a PR, so document that formula changes land by PR and record the bump checklist. Solves: a formula gate that silently tested nothing Tests: this PR is itself the check — it should build and test tailctl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the premise of
bdba9eb.brew test-botselects which formulae to build by diffingHEADagainstorigin/main. On a push to main those are the same commit, so the diff is empty and--only-formulaereports green having tested(none). Observed on two consecutive pushes — includinged3ad14, which did changeFormula/tailctl.rb.So running it on push cannot work, and the tap-new template's
if: github.event_name == 'pull_request'guard was right. Restored, with a comment explaining why it isn't an oversight.Added to the README: formula changes land via PR, plus the manual bump checklist (
livecheck→ update url/sha256 →install --build-from-source→test→audit --strict --online).This PR is its own test. It doesn't touch a formula, so
testing_formulaeshould again be(none)— the first PR that changestailctl.rbis what will finally exercise the gate end to end.