Slot1launch: Separate reading 1T-ROM and MROM cartridge headers - Fix address of ModuleParams - Fix loading and setting personalData#2597
Merged
RocketRobz merged 3 commits intoDS-Homebrew:masterfrom Nov 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Fixed issue preventing MROM DSi cartridges from launching in DSi mode (by splitting the code for reading the header for MROM and 1T-ROM). Also fixes launching cartridges in DSi mode in melonDS, since it assumes all cartridges are MROMs, even for big games like Pokémon Black (1T-ROM on real cartridges). melonDS slot1launch DSi mode support was broken by mistake in commit f181b22 , though since using DSi mode currently requires changing a define and the Makefile, it was not noticed.
Fixed the address used for ModuleParams (and adds a special case for SpiderMan 2 - USA). Previously, it wrongly assumed the magic values were at the beginning of ModuleParams, while they are at the end. This also fixes the various isSdk5 checks to work properly. In general, the isSdk5 check being fixed makes it so some DSi games that previously did not work now launch (and improves compatibility with forcing full DSi mode for some DS games, even though that's not a real goal). Finally, also introduces a NULL check to prevent reading bad data.
Fixed reading and changing the personalData (like the language) that is passed to the games. The pointers used were swapped. Though many games end up loading the data from the firmware regardless, so... It's more of a "that was wrong, let's fix it" kind of deal.
Ported from https://github.com/Lorenzooone/Simple-DS-Slot-1-Launcher
Where have you tested it?
3DS via TwilightMenu++ application and DSi via unlaunch + TwilightMenu++.
Tested with a retail DS cartridge, a retail DSi cartridge and a dev DSi cartridge with homebrew on it.
Also tested on melonDS, now that it works again.
Pull Request status