Skip to content

Bump org.postgresql:postgresql to 42.7.11#12403

Merged
tdonohue merged 3 commits intoDSpace:mainfrom
alanorth:postgres-checker-deps
May 5, 2026
Merged

Bump org.postgresql:postgresql to 42.7.11#12403
tdonohue merged 3 commits intoDSpace:mainfrom
alanorth:postgres-checker-deps

Conversation

@alanorth
Copy link
Copy Markdown
Contributor

@alanorth alanorth commented May 4, 2026

References

Add references/links to any related issues or PRs. These may include:

Description

Bump the bump org.postgresql:postgresql dependency to 42.7.11.

As a bonus, we can remove the explicit dependency on org.checkerframework:checker-qual because org.postgresql:postgresql no longer depends on it, which means we do not need to solve that particular dependency convergence issue anymore.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, update PostgreSQL JDBC driver dependency
  • Second, remove explicit version pin on transitive org.checkerframework:checker-qual dependency
  • Third, update comment in pom.xml

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

  • Make sure all tests in CI pass.
  • Make sure the application builds and runs.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

alanorth added 3 commits May 4, 2026 16:04
This was only pinned to avoid dependency convergence issues between
org.postgresql:postgresql and org.apache.solr:solr-core, but as of
version 42.7.11, org.postgresql:postgresql no longer depends on it.
Both com.google.guava:guava and org.apache.solr:solr-core depend on
org.checkerframework:checker-qual, but org.postgresql:postgresql no
longer does.
@alanorth alanorth added dependencies Pull requests that update a dependency file 1 APPROVAL pull request only requires a single approval to merge. labels May 4, 2026
@alanorth alanorth added port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels May 4, 2026
@tdonohue tdonohue added this to the 10.0 milestone May 5, 2026
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alanorth ! I deployed this locally and verified that everything is still working. I'm also glad to see we can remove that checker-qual dependency.

@github-project-automation github-project-automation Bot moved this to 👍 Reviewer Approved in DSpace 10.0 Release May 5, 2026
@tdonohue tdonohue merged commit dac8b2c into DSpace:main May 5, 2026
77 of 84 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release May 5, 2026
@dspace-bot
Copy link
Copy Markdown
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-12403-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-12403-to-dspace-7_x
git switch --create backport-12403-to-dspace-7_x
git cherry-pick -x 4494b7668697cf8a3783911ffc5b7d5506b57514 0cdde40242be6348f276e43d9967c3d0bbfaccb3 3c9c60c61f9d33868ca2ee2f786532eafa9a8149

@dspace-bot
Copy link
Copy Markdown
Contributor

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-12403-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-12403-to-dspace-8_x
git switch --create backport-12403-to-dspace-8_x
git cherry-pick -x 4494b7668697cf8a3783911ffc5b7d5506b57514 0cdde40242be6348f276e43d9967c3d0bbfaccb3 3c9c60c61f9d33868ca2ee2f786532eafa9a8149

@dspace-bot
Copy link
Copy Markdown
Contributor

Backport failed for dspace-9_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-9_x
git worktree add -d .worktree/backport-12403-to-dspace-9_x origin/dspace-9_x
cd .worktree/backport-12403-to-dspace-9_x
git switch --create backport-12403-to-dspace-9_x
git cherry-pick -x 4494b7668697cf8a3783911ffc5b7d5506b57514 0cdde40242be6348f276e43d9967c3d0bbfaccb3 3c9c60c61f9d33868ca2ee2f786532eafa9a8149

@tdonohue
Copy link
Copy Markdown
Member

tdonohue commented May 5, 2026

@alanorth : It looks like this was unable to be automatically backported to 9.x, 8.x and 7.x. Would you be able to make backport PR(s) for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge. dependencies Pull requests that update a dependency file port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants