[DS-1231] Indexing both stored and display-value from input-forms for search by iostath · Pull Request #55 · DSpace/DSpace

iostath · 2012-08-08T14:13:22Z

EKT's extension to index both stored and display-value from input-forms for search.
The extension is configurable from dspace.cfg

https://jira.duraspace.org/browse/DS-1231

helix84 · 2012-08-08T15:22:28Z

I think this belongs to DS-1231, not DS-1225, correct? If you can confirm, I'll change the title.

iostath · 2012-08-08T15:47:07Z

Oh! Yes! My mistake! Thanks!:-)

Στις 8/8/2012 6:22 μμ, ο/η helix84 έγραψε:

I think this belongs to DS-1231, not DS-1225, correct? If you can
confirm, I'll change the title.

—
Reply to this email directly or view it on GitHub
#55 (comment).

All functions in gr.ekt.repositories.dspace.utils.Utilities.java were transfered in org.dspace.app.util.Util.java Documentation added for the above functions

…localized input-forms if the user specifies 'inputform' in Search Index Configuration of dspace.cfg, e.g: search.index.12 = language:dc.language:inputform

DS-1217 Porting Discovery to the JSPUI

DS-1228 Concatenate values of multi-value fields in item display Squashed commit of the following: commit 79f87c3e2fcf00dd3aa7e2b5f4a5bc88d0482da1 Author: Andrea Bollini <bollini@cilea.it> Date: Thu Sep 13 16:36:16 2012 +0200 fixed indentation and compilation error (missing ;) commit 4ad5a517e3755de620e49e2f8be020089dba624b Merge: 8115be2 7f287cf Author: Andrea Bollini <bollini@cilea.it> Date: Thu Sep 13 16:30:37 2012 +0200 Merge remote-tracking branch 'EKT/DS-1228' into DS-1228 commit 7f287cf Author: EKT <kstamatis@ekt.gr> Date: Mon Sep 10 13:38:22 2012 +0300 Remove configuration for including space - change configuration option name commit 8bfd621 Author: EKT <kstamatis@ekt.gr> Date: Mon Aug 6 15:06:40 2012 +0300 Add option to concatenate multiple values in item display instead of line break

abollini · 2012-09-13T16:11:43Z

in this case it is more appropriate to return immediately (the item is an inprogress submission so to discover the right collection you should queries the workspace and workflow tables)

Hello Andrea!
So if the collection is null, I have added to return null, and, in this case the DSIndexer has nothing to index
Do you think I should query the workspace and workflow tables to discover the right collection? Does DSpace in any case indexes also workflow or workspace items?
Many thanks!
Rania

not sure, I changed my initial opinion...
query the workspace/workflow table could be better but as actually these items are not indexed we only add dead code
throw an illegal argument exception saying that indexing of item without item is not supported should be the better option at the moment (this will prevent us in future to discover bug later if we start to index workflow/workspace items)iostath notifications@github.com ha scritto:> +

String toReturn="";

DCInput myInputs = null;

boolean myInputsFound=false;

String formFileName = I18nUtil.getInputFormsFileName(locale);

DCInputSet inputSet = null;

//Read the input form file for the specific collection

DCInputsReader inputsReader = null;

String col_handle = "";

Collection collection = item.getOwningCollection();

if (collection==null)

{

col_handle = "db-id/" + item.getID();

Hello Andrea!
So if the collection is null, I have added to return null, and, in this case the DSIndexer has nothing to index
Do you think I should query the workspace and workflow tables to discover the right collection? Does DSpace in any case indexes also workflow or workspace items?
Many thanks!
Rania

Reply to this email directly or view it on GitHub:
https://github.com/DSpace/DSpace/pull/55/files#r1609540

DS-1236 Auto update advance search drop down lists from configuration file Squashed commit of the following: commit 612ac62f740fc26cd10d8a338db3537c49b3d4bd Author: Andrea Bollini <bollini@cilea.it> Date: Fri Sep 14 10:38:05 2012 +0200 I18N fix, improved configuration and code readability included the default index in the configuration refactored the jsp to reduce code for backward compatibility fixed messages.properties key to use a common strategy to derive it from the search index commit 81b3da2 Author: EKT <kstamatis@ekt.gr> Date: Fri Sep 14 08:43:33 2012 +0300 Conflicts: dspace/config/dspace.cfg

[DS-1244] XMLUI's OpenSearch implementation refactored to work with Discovery Squashed commit of the following: commit 1268c9af08018afb46d213910d8a96c79d20715c Author: Andrea Bollini <bollini@cilea.it> Date: Fri Sep 14 16:11:02 2012 +0200 Fix JSPUI side to work with new classes also included some bug fix about I18N access in Open Search for JSPUI commit 885012fcf32943dc1ce2ac7f35bb3810f70363aa Merge: 12b4d6b d8b1b4c Author: Andrea Bollini <bollini@cilea.it> Date: Fri Sep 14 15:28:09 2012 +0200 Merge remote-tracking branch 'sedici/open-search-discovery' into DS-1244 commit d8b1b4c Merge: 53ad4e3 58fe789 Author: Nestor Oviedo <nestor@pc-nestor.(none)> Date: Thu Sep 13 13:50:03 2012 -0300 Merge remote-tracking branch 'origin/open-search-discovery' into open-search-discovery Conflicts: dspace-jspui/dspace-jspui-api/src/main/java/org/dspace/app/webui/servlet/OpenSearchServlet.java Rebase with DSpace@7bc92a8 Conflict on dspace-jspui/dspace-jspui-api/src/main/java/org/dspace/app/webui/servlet/OpenSearchServlet.java resolved: new version preserved commit 53ad4e3 Author: nestor <nestor@pc-nestor> Date: Thu Sep 13 10:27:32 2012 -0300 Added license header to DiscoveryOpenSearchGenerator commit bdb22e0 Author: nestor <nestor@pc-nestor> Date: Thu Sep 6 13:36:01 2012 -0300 DS-1244 - XMLUI's OpenSearch implementation refactored. It's in order to use either PostgreSQL's indexes or Discovery services based on the requested URL commit 58fe789 Author: nestor <nestor@pc-nestor> Date: Thu Sep 13 10:27:32 2012 -0300 Added license header to DiscoveryOpenSearchGenerator commit efbf7d2 Author: nestor <nestor@pc-nestor> Date: Thu Sep 6 13:36:01 2012 -0300 DS-1244 - XMLUI's OpenSearch implementation refactored. It's in order to use either PostgreSQL's indexes or Discovery services based on the requested URL

…Localized returns a list of all the values and the DSIndexer manages these values) A return statement is added if the item has no collection

Code formatted using the dspace style eclipse formatter No store values in the index as the lucene projection is not currently used use generics to avoid raw type warning

abollini · 2012-09-15T15:39:06Z

just send you a pull request to EKT with some proposed changes

code formatted using the dspace eclipse format style
use of generic to avoid warning of the use of raw type
changed again the logic to use when there is not owning collection (more related to the DS-1225 that is used also to show preview of workspace and workflow item)

Ds 1231

[DS-1231] Indexing both stored and display-value from input-forms for search Squashed commit of the following: commit 426db18 Merge: b05c6a3 8334fce Author: kstamatis <kstamatis@ekt.gr> Date: Sat Sep 15 08:52:12 2012 -0700 Merge pull request #2 from abollini/DS-1231 Ds 1231 commit 8334fce Author: Andrea Bollini <bollini@cilea.it> Date: Sat Sep 15 17:31:08 2012 +0200 Use the default input set if the item is not yet archived commit c6be362 Author: Andrea Bollini <bollini@cilea.it> Date: Sat Sep 15 17:23:48 2012 +0200 Minor changes Code formatted using the dspace style eclipse formatter No store values in the index as the lucene projection is not currently used use generics to avoid raw type warning commit 6e6933d Merge: 3b1cc06 b05c6a3 Author: Andrea Bollini <bollini@cilea.it> Date: Sat Sep 15 16:19:20 2012 +0200 Merge remote-tracking branch 'EKT/DS-1231' into DS-1231 commit b05c6a3 Author: Rania Stathopoulou <iostath@ekt.gr> Date: Fri Sep 14 19:49:27 2012 +0300 Search indexing all values (now getControlledVocabulariesDisplayValueLocalized returns a list of all the values and the DSIndexer manages these values) A return statement is added if the item has no collection commit 33da186 Author: Rania Stathopoulou <iostath@ekt.gr> Date: Thu Sep 13 11:19:56 2012 +0300 Code Indentation commit c31651b Author: Rania Stathopoulou <iostath@ekt.gr> Date: Tue Sep 11 11:54:43 2012 +0300 Code changed in order to index both stored and display-value for all localized input-forms if the user specifies 'inputform' in Search Index Configuration of dspace.cfg, e.g: search.index.12 = language:dc.language:inputform commit d278958 Author: Rania Stathopoulou <iostath@ekt.gr> Date: Fri Sep 7 12:19:25 2012 +0300 Package name 'gr.ekt.repositories.dspace.utils' removed. All functions in gr.ekt.repositories.dspace.utils.Utilities.java were transfered in org.dspace.app.util.Util.java Documentation added for the above functions commit 8135fd4 Author: EKT <iostath@ekt.gr> Date: Wed Aug 8 18:40:40 2012 +0300 Unthrown exceptions added commit fa8796b Author: EKT <iostath@ekt.gr> Date: Wed Aug 8 17:06:20 2012 +0300 Indexing both stored and display-value from input-forms for search

abollini · 2012-09-17T09:15:44Z

this contribution has been merged after squash (commit link above)

[DS-1231] Indexing both stored and display-value from input-forms for search Squashed commit of the following: commit 426db18 Merge: b05c6a3 8334fce Author: kstamatis <kstamatis@ekt.gr> Date: Sat Sep 15 08:52:12 2012 -0700 Merge pull request #2 from abollini/DS-1231 Ds 1231 commit 8334fce Author: Andrea Bollini <bollini@cilea.it> Date: Sat Sep 15 17:31:08 2012 +0200 Use the default input set if the item is not yet archived commit c6be362 Author: Andrea Bollini <bollini@cilea.it> Date: Sat Sep 15 17:23:48 2012 +0200 Minor changes Code formatted using the dspace style eclipse formatter No store values in the index as the lucene projection is not currently used use generics to avoid raw type warning commit 6e6933d Merge: 3b1cc06 b05c6a3 Author: Andrea Bollini <bollini@cilea.it> Date: Sat Sep 15 16:19:20 2012 +0200 Merge remote-tracking branch 'EKT/DS-1231' into DS-1231 commit b05c6a3 Author: Rania Stathopoulou <iostath@ekt.gr> Date: Fri Sep 14 19:49:27 2012 +0300 Search indexing all values (now getControlledVocabulariesDisplayValueLocalized returns a list of all the values and the DSIndexer manages these values) A return statement is added if the item has no collection commit 33da186 Author: Rania Stathopoulou <iostath@ekt.gr> Date: Thu Sep 13 11:19:56 2012 +0300 Code Indentation commit c31651b Author: Rania Stathopoulou <iostath@ekt.gr> Date: Tue Sep 11 11:54:43 2012 +0300 Code changed in order to index both stored and display-value for all localized input-forms if the user specifies 'inputform' in Search Index Configuration of dspace.cfg, e.g: search.index.12 = language:dc.language:inputform commit d278958 Author: Rania Stathopoulou <iostath@ekt.gr> Date: Fri Sep 7 12:19:25 2012 +0300 Package name 'gr.ekt.repositories.dspace.utils' removed. All functions in gr.ekt.repositories.dspace.utils.Utilities.java were transfered in org.dspace.app.util.Util.java Documentation added for the above functions commit 8135fd4 Author: EKT <iostath@ekt.gr> Date: Wed Aug 8 18:40:40 2012 +0300 Unthrown exceptions added commit fa8796b Author: EKT <iostath@ekt.gr> Date: Wed Aug 8 17:06:20 2012 +0300 Indexing both stored and display-value from input-forms for search

Requested by CCAFS, as they are moving into Phase II and are updat- ing taxonomies. Addresses GitHub #55.

…idence-should-be-unset re DSpace#1514 setting authority.minconfidence to unset

…removing the header for the communities and collections, removing all template calls to print those results from discovery.xsl (DSpace#55)

removed optional dependencies from npm-shrinkwrap.json

Indexing both stored and display-value from input-forms for search

fa8796b

Unthrown exceptions added

8135fd4

iostath and others added 5 commits September 7, 2012 12:19

Package name 'gr.ekt.repositories.dspace.utils' removed.

d278958

All functions in gr.ekt.repositories.dspace.utils.Utilities.java were transfered in org.dspace.app.util.Util.java Documentation added for the above functions

Code changed in order to index both stored and display-value for all …

c31651b

…localized input-forms if the user specifies 'inputform' in Search Index Configuration of dspace.cfg, e.g: search.index.12 = language:dc.language:inputform

Code Indentation

33da186

Merge pull request DSpace#60 from abollini/DS-1217

8115be2

DS-1217 Porting Discovery to the JSPUI

abollini reviewed Sep 13, 2012
View reviewed changes

EKT and others added 8 commits September 14, 2012 10:54

Search indexing all values (now getControlledVocabulariesDisplayValue…

b05c6a3

…Localized returns a list of all the values and the DSIndexer manages these values) A return statement is added if the item has no collection

DS-1017: XMLUI mobile theme - initial contribution

449c7f9

add missing license headers in files from DS-1217

3b1cc06

Merge remote-tracking branch 'EKT/DS-1231' into DS-1231

6e6933d

Minor changes

c6be362

Code formatted using the dspace style eclipse formatter No store values in the index as the lucene projection is not currently used use generics to avoid raw type warning

Use the default input set if the item is not yet archived

8334fce

Merge pull request #2 from abollini/DS-1231

426db18

Ds 1231

abollini closed this Sep 17, 2012

alanorth referenced this pull request in alanorth/DSpace Jan 16, 2015

input-forms.xml: Update CCAFS subject terms

deaef61

Requested by CCAFS, as they are moving into Phase II and are updat- ing taxonomies. Addresses GitHub #55.

hardyoyo pushed a commit to hardyoyo/DSpace that referenced this pull request Oct 23, 2015

Merge pull request DSpace#55 from hardyoyo/lso-1514-authority.minconf…

5504f64

…idence-should-be-unset re DSpace#1514 setting authority.minconfidence to unset

antoine-atmire referenced this pull request in atmire/DSpace Oct 10, 2018

Merge pull request #55 from artlowel/shrinkwrap-optional-deps

cd3ebf0

removed optional dependencies from npm-shrinkwrap.json

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DS-1231] Indexing both stored and display-value from input-forms for search#55

[DS-1231] Indexing both stored and display-value from input-forms for search#55
iostath wants to merge 16 commits into
DSpace:masterfrom
EKT:DS-1231

iostath commented Aug 8, 2012

Uh oh!

helix84 commented Aug 8, 2012

Uh oh!

iostath commented Aug 8, 2012

Uh oh!

abollini Sep 13, 2012

Uh oh!

iostath Sep 14, 2012

Uh oh!

abollini Sep 14, 2012

Uh oh!

abollini commented Sep 15, 2012

Uh oh!

abollini commented Sep 17, 2012

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

iostath commented Aug 8, 2012

Uh oh!

helix84 commented Aug 8, 2012

Uh oh!

iostath commented Aug 8, 2012

Uh oh!

abollini Sep 13, 2012

Choose a reason for hiding this comment

Uh oh!

iostath Sep 14, 2012

Choose a reason for hiding this comment

Uh oh!

abollini Sep 14, 2012

Choose a reason for hiding this comment

Uh oh!

abollini commented Sep 15, 2012

Uh oh!

abollini commented Sep 17, 2012

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants