Skip to content

/api/security/csrf: better explain impact on perfomance degradation#283

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
saschaszott:patch-8
Aug 27, 2024
Merged

/api/security/csrf: better explain impact on perfomance degradation#283
tdonohue merged 1 commit intoDSpace:mainfrom
saschaszott:patch-8

Conversation

@saschaszott
Copy link
Copy Markdown
Contributor

No description provided.

@saschaszott
Copy link
Copy Markdown
Contributor Author

This PR is based on a Slack discussion between @tdonohue and @saschaszott . @tdonohue said

As far as I'm aware there's no way to perform a DoS style attack against the /api/security/csrf endpoint. It's just that clients should use it sparingly because the client's performance will be decreased it if has to request a CSRF token before every single POST/PUT/DELETE.

@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge. port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Aug 27, 2024
@tdonohue tdonohue added this to the 9.0 milestone Aug 27, 2024
@tdonohue tdonohue merged commit 5773d69 into DSpace:main Aug 27, 2024
@dspace-bot
Copy link
Copy Markdown

Successfully created backport PR for dspace-7_x:

@dspace-bot
Copy link
Copy Markdown

Successfully created backport PR for dspace-8_x:

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge.

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants