[DSpace-CRIS] Administrative Edit of archived items via submission form and security configuration for metadata visibility (Rest Contract)#330
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Apr 10, 2026
Conversation
10 tasks
tdonohue
requested changes
Mar 31, 2026
Member
tdonohue
left a comment
There was a problem hiding this comment.
Hi @AdamF42 ! I finally got around to reviewing this REST Contract. Overall, this looks good, but there's a few things that are missing (based on comparison with the DSpace/DSpace#11964 PR). I've listed them inline below.
Keep in mind, this REST Contract PR does NOT need to be closed this week (or prior to Testathon). This is essentially documentation, so it won't block merging the actual feature PR from being merged. Therefore, you have more time to work on updating this REST Contract PR.
Member
|
@AdamF42 : Friendly reminder to please update this REST Contract PR per the feedback above. I'd like to get this officially merged since the code it pertains to is all merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rest contract updates for 11964
Resolves DSpace/DSpace#12166