Defining relationships in submission forms: selectableRelationship should not be an array#69
Merged
tdonohue merged 2 commits intoDSpace:masterfrom Aug 5, 2019
Merged
Conversation
benbosman
added a commit
to atmire/DSpace
that referenced
this pull request
Aug 5, 2019
Adding JavaDoc Processing DSpace/RestContract#69
AlexanderS
approved these changes
Aug 5, 2019
Contributor
AlexanderS
left a comment
AlexanderS
left a comment
There was a problem hiding this comment.
Obvious fix.
Note: I just created a PR to fix the indentation: atmire#2
tdonohue
approved these changes
Aug 5, 2019
Member
|
@benbosman : This looks good to me too. However, I agree with @AlexanderS that there's a small indentation issue here. If you want to merge his small fix into your local repo, then we can immediately merge this PR! |
Member
Author
|
Thanks for the fast reviews, I've merged @AlexanderS his indentation improvement |
4science-it
pushed a commit
to 4Science/Rest7Contract
that referenced
this pull request
Oct 14, 2024
[DSC-1195] Approved-by: Vincenzo Mecca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a correction to #64
The selectableRelationship was accidentally defined as an array (similar to selectableMetadata). Only one selectableRelationship was supposed to be used.