Skip to content

Bugs on Collection Item Template fix#1064

Merged
tdonohue merged 2 commits intoDSpace:mainfrom
atmire:w2p-77742_Collection-item-template-bugfixes
Mar 29, 2021
Merged

Bugs on Collection Item Template fix#1064
tdonohue merged 2 commits intoDSpace:mainfrom
atmire:w2p-77742_Collection-item-template-bugfixes

Conversation

@Raf-atmire
Copy link
Copy Markdown
Contributor

References

Description

This PR fixes all the bugs listed in the above mentioned issue with regards to the Collection's item template

Instructions for Reviewers

List of changes in this PR:

  • Ensured that the Item template is getting used in the edit template item screen instead of the collection's metadata
  • Ensured that adding/deleting metadata works properly without errors
  • Ensured that the delete call only returns one notification

How to test this PR

  • Build this Angular branch
  • Go to a collection and create an Item template
  • Add and delete metadatavalues, ensure that it works
  • Delete the item template afterwards, ensure that only one notification is shown

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@artlowel artlowel added this to the 7.0beta5 milestone Mar 17, 2021
@artlowel artlowel added bug e/6 Estimate in hours labels Mar 17, 2021
@tdonohue tdonohue requested a review from atarix83 March 18, 2021 15:24
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Mar 18, 2021
Copy link
Copy Markdown
Contributor

@atarix83 atarix83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Raf-atmire for this PR

I had a look to the code and it seems good. I've also checked that all problems are resolved with this PR

@tdonohue tdonohue merged commit 3e0daef into DSpace:main Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug e/6 Estimate in hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Several bugs on collection's item template

5 participants