Skip to content

Fix edit group navigation bug#1146

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
atmire:w2p-79220_fix-edit-group-navigation-bug
May 7, 2021
Merged

Fix edit group navigation bug#1146
tdonohue merged 1 commit intoDSpace:mainfrom
atmire:w2p-79220_fix-edit-group-navigation-bug

Conversation

@bruno-atmire
Copy link
Copy Markdown
Contributor

References

Fixes #1127

Description

When navigating away from an "edit group" page (Access Control), the group list would be shown, regardless of user intentions. This PR eliminates a call to router.navigate such that navigation works again as intended.

Instructions for Reviewers

  • Log into DSpace
  • Open the group list (sidebar > Access Control > Groups)
  • Open the edit page of any group
  • Navigate to any page and observe that the expected page is opened. (Without this PR, the group list would always open.)

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@bruno-atmire bruno-atmire self-assigned this May 4, 2021
@artlowel artlowel added 1 APPROVAL pull request only requires a single approval to merge bug component: administrative tools Related to the admin menu or tools e/1 Estimate in hours high priority testathon Reported by a tester during Community Testathon labels May 4, 2021
@artlowel artlowel added this to the 7.0 milestone May 4, 2021
@tdonohue tdonohue requested a review from atarix83 May 6, 2021 14:58
Copy link
Copy Markdown
Contributor

@atarix83 atarix83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bruno-atmire for this PR.
I've verified that it resolves the annoying bug

@tdonohue tdonohue merged commit a87bf00 into DSpace:main May 7, 2021
atarix83 pushed a commit to 4Science/dspace-angular that referenced this pull request Dec 27, 2023
DSC-1434 update to x button

Approved-by: Davide Negretti
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: administrative tools Related to the admin menu or tools e/1 Estimate in hours high priority testathon Reported by a tester during Community Testathon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in Navigation - Current Members in Edit group page

4 participants