Delete pending json patch operations#1251
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Jun 30, 2021
Merged
Conversation
tdonohue
approved these changes
Jun 30, 2021
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alemarte ! I've tested this today... I was able to verify the bug from the ticket using the demo site, and verify also that this PR fixes that issue. The code looks good and it comes with tests to prove it's working as expected. Thanks!
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Jan 26, 2024
…Space#1251) DSC-1073 - fix typo Approved-by: Stefano Maffei
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
When the user leaves the submission page the state related to the aborted submission must be totally erased.
Instructions for Reviewers
To achieve the goal a new NgRx Action has been added (
DELETE_PENDING_JSON_PATCH_OPERATIONS). This action is dispatched on the OnDestroy hook of theSubmissionEditComponent. The reducer destroy every data related to the aborted submission.Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.