Skip to content

Fix issue when switching submission's collection between those with different submission definition#1253

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
4Science:#1234
Jun 28, 2021
Merged

Fix issue when switching submission's collection between those with different submission definition#1253
tdonohue merged 1 commit intoDSpace:mainfrom
4Science:#1234

Conversation

@atarix83
Copy link
Copy Markdown
Contributor

References

Description

Fix issue when switching submission's collection between those with different submission definition

Instructions for Reviewers

Follow instruction present in the #1234 and check the issue is not present anymore

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge bug component: submission medium priority labels Jun 24, 2021
@tdonohue tdonohue added this to the 7.0 milestone Jun 24, 2021
@tdonohue tdonohue self-requested a review June 24, 2021 19:04
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested this by creating a submission for a default Item, then switching Collection to ones that had Entity specific forms...the new forms were loaded properly. Thanks @atarix83 !

@tdonohue tdonohue merged commit e6c2680 into DSpace:main Jun 28, 2021
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Feb 9, 2024
Gdpr metrics 2023 02 x DSC-1413

Approved-by: Giuseppe Digilio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: submission medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switching submission collection between ones with different submission definitions doesn't work

2 participants